Commit 756baca2 authored by Brian Foster's avatar Brian Foster Committed by Darrick J. Wong
Browse files

xfs: support ability to wait on new inodes 



Inodes that are inserted into the perag tree but still under
construction are flagged with the XFS_INEW bit. Most contexts either
skip such inodes when they are encountered or have the ability to
handle them.

The runtime quotaoff sequence introduces a context that must wait
for construction of such inodes to correctly ensure that all dquots
in the fs are released. In anticipation of this, support the ability
to wait on new inodes. Wake the appropriate bit when XFS_INEW is
cleared.

Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 8f720d9f

fs/xfs/xfs_icache.c

+4 −1
Original line number Diff line number Diff line
@@ -366,14 +366,17 @@ xfs_iget_cache_hit( 


		error = xfs_reinit_inode(mp, inode);

		if (error) {

			bool wake;

			/*

			 * Re-initializing the inode failed, and we are in deep

			 * trouble.  Try to re-add it to the reclaim list.

			 */

			rcu_read_lock();

			spin_lock(&ip->i_flags_lock);



			wake = !!__xfs_iflags_test(ip, XFS_INEW);

			ip->i_flags &= ~(XFS_INEW | XFS_IRECLAIM);

			if (wake)

				wake_up_bit(&ip->i_flags, __XFS_INEW_BIT);

			ASSERT(ip->i_flags & XFS_IRECLAIMABLE);

			trace_xfs_iget_reclaim_fail(ip);

			goto out_error;

fs/xfs/xfs_inode.h

+3 −1
Original line number Diff line number Diff line
@@ -216,7 +216,8 @@ static inline bool xfs_is_reflink_inode(struct xfs_inode *ip) 
#define XFS_IRECLAIM		(1 << 0) /* started reclaiming this inode */

#define XFS_ISTALE		(1 << 1) /* inode has been staled */

#define XFS_IRECLAIMABLE	(1 << 2) /* inode can be reclaimed */

#define XFS_INEW		(1 << 3) /* inode has just been allocated */

#define __XFS_INEW_BIT		3	 /* inode has just been allocated */

#define XFS_INEW		(1 << __XFS_INEW_BIT)

#define XFS_ITRUNCATED		(1 << 5) /* truncated down so flush-on-close */

#define XFS_IDIRTY_RELEASE	(1 << 6) /* dirty release already seen */

#define __XFS_IFLOCK_BIT	7	 /* inode is being flushed right now */
@@ -464,6 +465,7 @@ static inline void xfs_finish_inode_setup(struct xfs_inode *ip) 
	xfs_iflags_clear(ip, XFS_INEW);

	barrier();

	unlock_new_inode(VFS_I(ip));

	wake_up_bit(&ip->i_flags, __XFS_INEW_BIT);

}



static inline void xfs_setup_existing_inode(struct xfs_inode *ip)

CRA Git | Maintained and supported by SUSTech CRA and CCSE