Commit 7559d13c authored Dec 21, 2014 by Shuah Khan Committed by Mauro Carvalho Chehab Feb 02, 2015

[media] media: fix au0828_analog_register() to not free au0828_dev



au0828_analog_register() frees au0828_dev when it fails to
locate isoc endpoint. au0828_usb_probe() continues with dvb
and rc probe and registration assuming dev is still valid.
When au0828_analog_register() fails to locate isoc endpoint,
it should return without free'ing au0828_dev. Otherwise, the
probe will fail as dev is null when au0828_dvb_register() is
called.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 614b4384

drivers/media/usb/au0828/au0828-video.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2029,7 +2029,6 @@ int au0828_analog_register(struct au0828_dev *dev,
		}
		if (!(dev->isoc_in_endpointaddr)) {
		pr_info("Could not locate isoc endpoint\n");
		kfree(dev);
		return -ENODEV;
		}

Admin message