Commit 754f40e0 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Li Yang
Browse files

soc: fsl: qe: make cpm_muram_free() return void 



Nobody uses the return value from cpm_muram_free, and functions that
free resources usually return void. One could imagine a use for a "how
much have I allocated" a la ksize(), but knowing how much one had
access to after the fact is useless.

Reviewed-by: default avatarTimur Tabi <timur@kernel.org>
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarLi Yang <leoyang.li@nxp.com>
parent 800cd6fb

drivers/soc/fsl/qe/qe_common.c

+1 −2
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ EXPORT_SYMBOL(cpm_muram_alloc); 
 * cpm_muram_free - free a chunk of multi-user ram

 * @offset: The beginning of the chunk as returned by cpm_muram_alloc().

 */

int cpm_muram_free(s32 offset)

void cpm_muram_free(s32 offset)

{

	unsigned long flags;

	int size;
@@ -188,7 +188,6 @@ int cpm_muram_free(s32 offset) 
	}

	gen_pool_free(muram_pool, offset + GENPOOL_OFFSET, size);

	spin_unlock_irqrestore(&cpm_muram_lock, flags);

	return size;

}

EXPORT_SYMBOL(cpm_muram_free);

include/soc/fsl/qe/qe.h

+2 −3
Original line number Diff line number Diff line
@@ -99,7 +99,7 @@ int cpm_muram_init(void); 


#if defined(CONFIG_CPM) || defined(CONFIG_QUICC_ENGINE)

s32 cpm_muram_alloc(unsigned long size, unsigned long align);

int cpm_muram_free(s32 offset);

void cpm_muram_free(s32 offset);

s32 cpm_muram_alloc_fixed(unsigned long offset, unsigned long size);

void __iomem *cpm_muram_addr(unsigned long offset);

unsigned long cpm_muram_offset(void __iomem *addr);
@@ -111,9 +111,8 @@ static inline s32 cpm_muram_alloc(unsigned long size, 
	return -ENOSYS;

}



static inline int cpm_muram_free(s32 offset)

static inline void cpm_muram_free(s32 offset)

{

	return -ENOSYS;

}



static inline s32 cpm_muram_alloc_fixed(unsigned long offset,

CRA Git | Maintained and supported by SUSTech CRA and CCSE