Commit 753a9870 authored by Mircea Caprioru's avatar Mircea Caprioru Committed by Jonathan Cameron
Browse files

staging: iio: adc: ad7192: Report error directly in ad7192_setup 



This patch removes the goto out statement and uninformative
print message. This improves readability.

Signed-off-by: default avatarMircea Caprioru <mircea.caprioru@analog.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 3ad7a939

drivers/staging/iio/adc/ad7192.c

+5 −8
Original line number Diff line number Diff line
@@ -260,13 +260,13 @@ static int ad7192_setup(struct ad7192_state *st, 
	/* reset the serial interface */

	ret = ad_sd_reset(&st->sd, 48);

	if (ret < 0)

		goto out;

		return ret;

	usleep_range(500, 1000); /* Wait for at least 500us */



	/* write/read test for device presence */

	ret = ad_sd_read_reg(&st->sd, AD7192_REG_ID, 1, &id);

	if (ret)

		goto out;

		return ret;



	id &= AD7192_ID_MASK;
@@ -314,15 +314,15 @@ static int ad7192_setup(struct ad7192_state *st, 


	ret = ad_sd_write_reg(&st->sd, AD7192_REG_MODE, 3, st->mode);

	if (ret)

		goto out;

		return ret;



	ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, st->conf);

	if (ret)

		goto out;

		return ret;



	ret = ad7192_calibrate_all(st);

	if (ret)

		goto out;

		return ret;



	/* Populate available ADC input ranges */

	for (i = 0; i < ARRAY_SIZE(st->scale_avail); i++) {
@@ -336,9 +336,6 @@ static int ad7192_setup(struct ad7192_state *st, 
	}



	return 0;

out:

	dev_err(&st->sd.spi->dev, "setup failed\n");

	return ret;

}



static ssize_t

CRA Git | Maintained and supported by SUSTech CRA and CCSE