Commit 7536c7e0 authored May 28, 2020 by Qi Zheng Committed by Rob Herring May 28, 2020

of/fdt: Remove redundant kbasename function call



For version 1 to 3 of the device tree, this is the node full
path as a zero terminated string, starting with "/". The
following equation will not hold, since the node name has
been processed in the fdt_get_name().

	*pathp == '/'

For version 16 and later, this is the node unit name only
(or an empty string for the root node). So the above
equation will still not hold.

So the kbasename() is redundant, just remove it.

Signed-off-by: Qi Zheng <arch0.zheng@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>

parent 67e35adf

drivers/of/fdt.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -643,8 +643,6 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node,
		offset = fdt_next_node(blob, offset, &depth)) {

		pathp = fdt_get_name(blob, offset, NULL);
		if (*pathp == '/')
		pathp = kbasename(pathp);
		rc = it(offset, pathp, depth, data);
		}
		return rc;
		@@ -671,8 +669,6 @@ int __init of_scan_flat_dt_subnodes(unsigned long parent,
		int rc;

		pathp = fdt_get_name(blob, node, NULL);
		if (*pathp == '/')
		pathp = kbasename(pathp);
		rc = it(node, pathp, data);
		if (rc)
		return rc;

Admin message