Commit 753419f5 authored Sep 30, 2010 by Vishwanath BS Committed by Jean Delvare Sep 30, 2010

i2c: Fix for suspend/resume issue



In current i2c core driver, call to pm_runtime_set_active from
i2c_device_pm_resume will unconditionally enable i2c module and
increment child count of the parent. Because of this, in CPU Idle
path, i2c does not idle, preventing Core to enter retention. Also i2c
module will not be suspended upon system suspend as
pm_runtime_set_suspended is not called from i2c_device_pm_suspend.

This issue is fixed by removing pm_runtime_set_active call from resume
path which is not necessary.
This fix has been tested on OMAP4430.

Signed-off-by: Partha Basak <p-basak2@ti.com>
Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent 59bfee6e

drivers/i2c/i2c-core.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -216,12 +216,6 @@ static int i2c_device_pm_resume(struct device *dev)
		else
		ret = i2c_legacy_resume(dev);

		if (!ret) {
		pm_runtime_disable(dev);
		pm_runtime_set_active(dev);
		pm_runtime_enable(dev);
		}

		return ret;
		}

Admin message