Commit 753162cd authored Feb 10, 2015 by Andrey Ryabinin Committed by Linus Torvalds Feb 10, 2015

mm: hugetlb: fix type of hugetlb_treat_as_movable variable



hugetlb_treat_as_movable declared as unsigned long, but
proc_dointvec() used for parsing it:

static struct ctl_table vm_table[] = {
...
        {
                .procname	= "hugepages_treat_as_movable",
                .data		= &hugepages_treat_as_movable,
                .maxlen		= sizeof(int),
                .mode		= 0644,
                .proc_handler	= proc_dointvec,
        },

This seems harmless, but it's better to use int type here.

Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3cd7645d

include/linux/hugetlb.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ void free_huge_page(struct page *page);
		pte_t huge_pmd_share(struct mm_struct mm, unsigned long addr, pud_t *pud);
		#endif

		extern unsigned long hugepages_treat_as_movable;
		extern int hugepages_treat_as_movable;
		extern int sysctl_hugetlb_shm_group;
		extern struct list_head huge_boot_pages;

mm/hugetlb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -35,7 +35,7 @@
		#include <linux/node.h>
		#include "internal.h"

		unsigned long hugepages_treat_as_movable;
		int hugepages_treat_as_movable;

		int hugetlb_max_hstate __read_mostly;
		unsigned int default_hstate_idx;

Admin message