Unverified Commit 752c938a authored Sep 25, 2019 by Dan Carpenter Committed by Mark Brown Sep 26, 2019

ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create()



The "template.id" variable is an enum and in this context GCC will
treat it as an unsigned int so it can never be less than zero.

Fixes: 8a978234 ("ASoC: topology: Add topology core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190925110624.GR3264@mwanda


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 901e822b

sound/soc/soc-topology.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1588,7 +1588,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,

		/* map user to kernel widget ID */
		template.id = get_widget_id(le32_to_cpu(w->id));
		if (template.id < 0)
		if ((int)template.id < 0)
		return template.id;

		/* strings are allocated here, but used and freed by the widget */

Admin message