Commit 751bf4d7 authored by James Bottomley's avatar James Bottomley
Browse files

[SCSI] scsi_sysfs: restore prep_fn when ULD is removed 

A recent bug report:

http://bugzilla.kernel.org/show_bug.cgi?id=9674



Was caused because the ULDs now set their own prep functions, but
don't necessarily reset the prep function back to the SCSI default
when they are removed.  This leads to panics if commands are sent to
the device after the module is removed because the prep_fn is still
pointing to the old module code.  The fix for this is to implement a
bus remove method that resets the prep_fn pointer correctly before
calling the ULD specific driver remove method.

Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent dc512814

drivers/scsi/scsi_lib.c

+1 −1
Original line number Diff line number Diff line
@@ -1332,7 +1332,7 @@ int scsi_prep_return(struct request_queue *q, struct request *req, int ret) 
}

EXPORT_SYMBOL(scsi_prep_return);



static int scsi_prep_fn(struct request_queue *q, struct request *req)

int scsi_prep_fn(struct request_queue *q, struct request *req)

{

	struct scsi_device *sdev = q->queuedata;

	int ret = BLKPREP_KILL;

drivers/scsi/scsi_priv.h

+3 −0
Original line number Diff line number Diff line
@@ -74,6 +74,9 @@ extern struct request_queue *scsi_alloc_queue(struct scsi_device *sdev); 
extern void scsi_free_queue(struct request_queue *q);

extern int scsi_init_queue(void);

extern void scsi_exit_queue(void);

struct request_queue;

struct request;

extern int scsi_prep_fn(struct request_queue *, struct request *);



/* scsi_proc.c */

#ifdef CONFIG_SCSI_PROC_FS

drivers/scsi/scsi_sysfs.c

+17 −0
Original line number Diff line number Diff line
@@ -373,12 +373,29 @@ static int scsi_bus_resume(struct device * dev) 
	return err;

}



static int scsi_bus_remove(struct device *dev)

{

	struct device_driver *drv = dev->driver;

	struct scsi_device *sdev = to_scsi_device(dev);

	int err = 0;



	/* reset the prep_fn back to the default since the

	 * driver may have altered it and it's being removed */

	blk_queue_prep_rq(sdev->request_queue, scsi_prep_fn);



	if (drv && drv->remove)

		err = drv->remove(dev);



	return 0;

}



struct bus_type scsi_bus_type = {

        .name		= "scsi",

        .match		= scsi_bus_match,

	.uevent		= scsi_bus_uevent,

	.suspend	= scsi_bus_suspend,

	.resume		= scsi_bus_resume,

	.remove		= scsi_bus_remove,

};



int scsi_sysfs_register(void)

CRA Git | Maintained and supported by SUSTech CRA and CCSE