Commit 7507c402 authored May 14, 2019 by Andrew Morton Committed by Linus Torvalds May 14, 2019

lib/test_vmalloc.c:test_func(): eliminate local `ret'



Local 'ret' is unneeded and was poorly named: the variable `ret'
generally means the "the value which this function will return".

Cc: Roman Gushchin <guro@fb.com>
Cc: Uladzislau Rezki <urezki@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Thomas Garnier <thgarnie@google.com>
Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Joel Fernandes <joelaf@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ef4d6f6b

lib/test_vmalloc.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -384,12 +384,11 @@ static int test_func(void *private)
		{
		struct test_driver *t = private;
		int random_array[ARRAY_SIZE(test_case_array)];
		int index, i, j, ret;
		int index, i, j;
		ktime_t kt;
		u64 delta;

		ret = set_cpus_allowed_ptr(current, cpumask_of(t->cpu));
		if (ret < 0)
		if (set_cpus_allowed_ptr(current, cpumask_of(t->cpu)) < 0)
		pr_err("Failed to set affinity to %d CPU\n", t->cpu);

		for (i = 0; i < ARRAY_SIZE(test_case_array); i++)
		@@ -415,8 +414,7 @@ static int test_func(void *private)

		kt = ktime_get();
		for (j = 0; j < test_repeat_count; j++) {
		ret = test_case_array[index].test_func();
		if (!ret)
		if (!test_case_array[index].test_func())
		per_cpu_test_data[t->cpu][index].test_passed++;
		else
		per_cpu_test_data[t->cpu][index].test_failed++;

Admin message