Commit 74ca0d83 authored Aug 28, 2020 by Krzysztof Kozlowski

memory: brcmstb_dpfe: Simplify with dev_err_probe()



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Markus Mayer <mmayer@broadcom.com>
Link: https://lore.kernel.org/r/20200828153747.22358-1-krzk@kernel.org

parent 4c2af5dd

drivers/memory/brcmstb_dpfe.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
		}

		ret = brcmstb_dpfe_download_firmware(priv);
		if (ret) {
		if (ret != -EPROBE_DEFER)
		dev_err(dev, "Couldn't download firmware -- %d\n", ret);
		return ret;
		}
		if (ret)
		return dev_err_probe(dev, ret, "Couldn't download firmware\n");

		ret = sysfs_create_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs);
		if (!ret)

Admin message