Commit 74bf71ed authored Jul 26, 2019 by Samuel Thibault Committed by Takashi Iwai Jul 27, 2019

ALSA: hda: Fix 1-minute detection delay when i915 module is not available

Distribution installation images such as Debian include different sets
of modules which can be downloaded dynamically.  Such images may notably
include the hda sound modules but not the i915 DRM module, even if the
latter was enabled at build time, as reported on
https://bugs.debian.org/931507



In such a case hdac_i915 would be linked in and try to load the i915
module, fail since it is not there, but still wait for a whole minute
before giving up binding with it.

This fixes such as case by only waiting for the binding if the module
was properly loaded (or module support is disabled, in which case i915
is already compiled-in anyway).

Fixes: f9b54e19 ("ALSA: hda/i915: Allow delayed i915 audio component binding")
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 3f880949

sound/hda/hdac_i915.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -136,11 +136,13 @@ int snd_hdac_i915_init(struct hdac_bus *bus)
		if (!acomp)
		return -ENODEV;
		if (!acomp->ops) {
		request_module("i915");
		if (!IS_ENABLED(CONFIG_MODULES) \|\|
		!request_module("i915")) {
		/* 60s timeout */
		wait_for_completion_timeout(&bind_complete,
		msecs_to_jiffies(60 * 1000));
		}
		}
		if (!acomp->ops) {
		dev_info(bus->dev, "couldn't bind with audio component\n");
		snd_hdac_acomp_exit(bus);

Admin message