Commit 74af4c17 authored by Kaixu Xia's avatar Kaixu Xia Committed by Darrick J. Wong
Browse files

xfs: remove the unused parameter id from xfs_qm_dqattach_one 



Since we never use the second parameter id, so remove it from
xfs_qm_dqattach_one() function.

Signed-off-by: default avatarKaixu Xia <kaixuxia@tencent.com>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent 3feb4ffb

fs/xfs/xfs_qm.c

+5 −6
Original line number Diff line number Diff line
@@ -249,7 +249,6 @@ xfs_qm_unmount_quotas( 
STATIC int

xfs_qm_dqattach_one(

	struct xfs_inode	*ip,

	xfs_dqid_t		id,

	xfs_dqtype_t		type,

	bool			doalloc,

	struct xfs_dquot	**IO_idqpp)
@@ -330,23 +329,23 @@ xfs_qm_dqattach_locked( 
	ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));



	if (XFS_IS_UQUOTA_ON(mp) && !ip->i_udquot) {

		error = xfs_qm_dqattach_one(ip, i_uid_read(VFS_I(ip)),

				XFS_DQTYPE_USER, doalloc, &ip->i_udquot);

		error = xfs_qm_dqattach_one(ip, XFS_DQTYPE_USER,

				doalloc, &ip->i_udquot);

		if (error)

			goto done;

		ASSERT(ip->i_udquot);

	}



	if (XFS_IS_GQUOTA_ON(mp) && !ip->i_gdquot) {

		error = xfs_qm_dqattach_one(ip, i_gid_read(VFS_I(ip)),

				XFS_DQTYPE_GROUP, doalloc, &ip->i_gdquot);

		error = xfs_qm_dqattach_one(ip, XFS_DQTYPE_GROUP,

				doalloc, &ip->i_gdquot);

		if (error)

			goto done;

		ASSERT(ip->i_gdquot);

	}



	if (XFS_IS_PQUOTA_ON(mp) && !ip->i_pdquot) {

		error = xfs_qm_dqattach_one(ip, ip->i_d.di_projid, XFS_DQTYPE_PROJ,

		error = xfs_qm_dqattach_one(ip, XFS_DQTYPE_PROJ,

				doalloc, &ip->i_pdquot);

		if (error)

			goto done;

CRA Git | Maintained and supported by SUSTech CRA and CCSE