hwmon: (pmbus/ibm-cffps) Fix the LED behavior when turned off (74a71a83) · Commits · 戴 / test

The driver should remain in control of the LED on the PSU, even while off, not the PSU firmware as previously indicated. Signed-off-by:

drivers/hwmon/pmbus/ibm-cffps.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -47,13 +47,9 @@
		#define CFFPS_MFR_VAUX_FAULT BIT(6)
		#define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7)

		/*
		* LED off state actually relinquishes LED control to PSU firmware, so it can
		* turn on the LED for faults.
		*/
		#define CFFPS_LED_OFF 0
		#define CFFPS_LED_BLINK BIT(0)
		#define CFFPS_LED_ON BIT(1)
		#define CFFPS_LED_OFF BIT(2)
		#define CFFPS_BLINK_RATE_MS 250

		enum {
		@@ -436,6 +432,9 @@ static void ibm_cffps_create_led_class(struct ibm_cffps *psu)
		rc = devm_led_classdev_register(dev, &psu->led);
		if (rc)
		dev_warn(dev, "failed to register led class: %d\n", rc);
		else
		i2c_smbus_write_byte_data(client, CFFPS_SYS_CONFIG_CMD,
		CFFPS_LED_OFF);
		}

		static struct pmbus_driver_info ibm_cffps_info[] = {