Commit 749c59fd authored Aug 30, 2012 by Jamie Iles Committed by Avi Kivity Sep 04, 2012

KVM: PIC: fix use of uninitialised variable.

Commit aea218f3 (KVM: PIC: call ack notifiers for irqs that are
dropped form irr) used an uninitialised variable to track whether an
appropriate apic had been found.  This could result in calling the ack
notifier incorrectly.

Cc: Gleb Natapov <gleb@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent 5b716ac7

arch/x86/kvm/i8259.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -318,7 +318,7 @@ static void pic_ioport_write(void *opaque, u32 addr, u32 val)
		if (val & 0x10) {
		u8 edge_irr = s->irr & ~s->elcr;
		int i;
		bool found;
		bool found = false;
		struct kvm_vcpu *vcpu;

		s->init4 = val & 1;

Admin message