Commit 7496e053 authored Apr 25, 2014 by Mark Hounschell Committed by Greg Kroah-Hartman May 16, 2014

staging: dgap: check unchecked return values



Check the return values of dgap_tty_register and
dgap_finalize_board_init. If they fail for a
particular board we should not be able to try
to use that board. IE. no device entries shall
be created for that board.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cacaf104

drivers/staging/dgap/dgap.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -882,8 +882,13 @@ static int dgap_firmware_load(struct pci_dev *pdev, int card_type)
		return -EINVAL;
		}

		dgap_tty_register(brd);
		dgap_finalize_board_init(brd);
		ret = dgap_tty_register(brd);
		if (ret)
		return ret;

		ret = dgap_finalize_board_init(brd);
		if (ret)
		return ret;

		if (fw_info[card_type].bios_name) {
		ret = request_firmware(&fw, fw_info[card_type].bios_name,

Admin message