r8152: check rx after napi is enabled (7489bdad) · Commits · 戴 / test

Schedule the napi after napi_enable() for rx, if it is necessary. If the rx is completed when napi is disabled, the sheduling of napi would be lost. Then, no one handles the rx packet until next napi is scheduled. Signed-off-by:

Hayes Wang <hayeswang@realtek.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/usb/r8152.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -32,7 +32,7 @@
		#define NETNEXT_VERSION "08"

		/* Information for net */
		#define NET_VERSION "7"
		#define NET_VERSION "8"

		#define DRIVER_VERSION "v1." NETNEXT_VERSION "." NET_VERSION
		#define DRIVER_AUTHOR "Realtek linux nic maintainers <nic_swsd@realtek.com>"
		@@ -3561,6 +3561,9 @@ static int rtl8152_post_reset(struct usb_interface *intf)
		netif_wake_queue(netdev);
		usb_submit_urb(tp->intr_urb, GFP_KERNEL);

		if (!list_empty(&tp->rx_done))
		napi_schedule(&tp->napi);

		return 0;
		}

		@@ -3700,6 +3703,8 @@ static int rtl8152_resume(struct usb_interface *intf)
		napi_enable(&tp->napi);
		clear_bit(SELECTIVE_SUSPEND, &tp->flags);
		smp_mb__after_atomic();
		if (!list_empty(&tp->rx_done))
		napi_schedule(&tp->napi);
		} else {
		tp->rtl_ops.up(tp);
		netif_carrier_off(tp->netdev);

Admin message