Commit 746e8d3b authored by Finn Thain's avatar Finn Thain Committed by Geert Uytterhoeven
Browse files

m68k: mac baboon interrupt enable/disable 



No-one seems to know how to mask individual baboon interrupts, so we just 
mask the umbrella IRQ. This will work as long as only the IDE driver uses 
the baboon chip (it can't deadlock). Use mac_enable_irq/mac_disable_irq 
rather than enable_irq/disable_irq because the latter routines count the 
depth of nested calls which triggers a warning and call trace because 
IRQ_NUBUS_C is enabled twice in a row (once when the baboon handler is 
registered, and once when the IDE IRQ is registered).

Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
parent 429dbf53

arch/m68k/mac/baboon.c

+31 −11
Original line number Diff line number Diff line
@@ -18,11 +18,14 @@ 
#include <asm/macints.h>

#include <asm/mac_baboon.h>



/* #define DEBUG_BABOON */

/* #define DEBUG_IRQS */



extern void mac_enable_irq(unsigned int);

extern void mac_disable_irq(unsigned int);



int baboon_present;

static volatile struct baboon *baboon;

static unsigned char baboon_disabled;



#if 0

extern int macide_ack_intr(struct ata_channel *);
@@ -88,26 +91,43 @@ static irqreturn_t baboon_irq(int irq, void *dev_id) 


void __init baboon_register_interrupts(void)

{

	request_irq(IRQ_NUBUS_C, baboon_irq, IRQ_FLG_LOCK|IRQ_FLG_FAST,

		    "baboon", (void *) baboon);

	baboon_disabled = 0;

	request_irq(IRQ_NUBUS_C, baboon_irq, 0, "baboon", (void *)baboon);

}



void baboon_irq_enable(int irq) {

/*

 * The means for masking individual baboon interrupts remains a mystery, so

 * enable the umbrella interrupt only when no baboon interrupt is disabled.

 */



void baboon_irq_enable(int irq)

{

	int irq_idx = IRQ_IDX(irq);



#ifdef DEBUG_IRQUSE

	printk("baboon_irq_enable(%d)\n", irq);

#endif

	/* FIXME: figure out how to mask and unmask baboon interrupt sources */

	enable_irq(IRQ_NUBUS_C);



	baboon_disabled &= ~(1 << irq_idx);

	if (!baboon_disabled)

		mac_enable_irq(IRQ_NUBUS_C);

}



void baboon_irq_disable(int irq) {

void baboon_irq_disable(int irq)

{

	int irq_idx = IRQ_IDX(irq);



#ifdef DEBUG_IRQUSE

	printk("baboon_irq_disable(%d)\n", irq);

#endif

	disable_irq(IRQ_NUBUS_C);



	baboon_disabled |= 1 << irq_idx;

	if (baboon_disabled)

		mac_disable_irq(IRQ_NUBUS_C);

}



void baboon_irq_clear(int irq) {

void baboon_irq_clear(int irq)

{

	int irq_idx = IRQ_IDX(irq);



	baboon->mb_ifr &= ~(1 << irq_idx);

arch/m68k/mac/macints.c

+4 −4
Original line number Diff line number Diff line
@@ -214,8 +214,8 @@ irqreturn_t mac_debug_handler(int, void *); 


/* #define DEBUG_MACINTS */



static void mac_enable_irq(unsigned int irq);

static void mac_disable_irq(unsigned int irq);

void mac_enable_irq(unsigned int irq);

void mac_disable_irq(unsigned int irq);



static struct irq_controller mac_irq_controller = {

	.name		= "mac",
@@ -274,7 +274,7 @@ void __init mac_init_IRQ(void) 
 * These routines are just dispatchers to the VIA/OSS/PSC routines.

 */



static void mac_enable_irq(unsigned int irq)

void mac_enable_irq(unsigned int irq)

{

	int irq_src = IRQ_SRC(irq);
@@ -307,7 +307,7 @@ static void mac_enable_irq(unsigned int irq) 
	}

}



static void mac_disable_irq(unsigned int irq)

void mac_disable_irq(unsigned int irq)

{

	int irq_src = IRQ_SRC(irq);

CRA Git | Maintained and supported by SUSTech CRA and CCSE