Commit 7455a832 authored Feb 14, 2020 by Miaohe Lin Committed by Paolo Bonzini Feb 21, 2020

KVM: x86: don't notify userspace IOAPIC on edge-triggered interrupt EOI



Commit 13db7734 ("KVM: x86: don't notify userspace IOAPIC on edge
EOI") said, edge-triggered interrupts don't set a bit in TMR, which means
that IOAPIC isn't notified on EOI. And var level indicates level-triggered
interrupt.
But commit 3159d36a ("KVM: x86: use generic function for MSI parsing")
replace var level with irq.level by mistake. Fix it by changing irq.level
to irq.trig_mode.

Cc: stable@vger.kernel.org
Fixes: 3159d36a ("KVM: x86: use generic function for MSI parsing")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent b78a8552

arch/x86/kvm/irq_comm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -417,7 +417,7 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu,

		kvm_set_msi_irq(vcpu->kvm, entry, &irq);

		if (irq.level &&
		if (irq.trig_mode &&
		kvm_apic_match_dest(vcpu, NULL, APIC_DEST_NOSHORT,
		irq.dest_id, irq.dest_mode))
		__set_bit(irq.vector, ioapic_handled_vectors);

Admin message