Commit 74478ea4 authored by Alex Elder's avatar Alex Elder Committed by David S. Miller
Browse files

net: ipa: fix QMI structure definition bugs 



Building with "W=1" did exactly what it was supposed to do, namely
point out some suspicious-looking code to be verified not to contain
bugs.

Some QMI message structures defined in "ipa_qmi_msg.c" contained
some bad field names (duplicating the "elem_size" field instead of
defining the "offset" field), almost certainly due to copy/paste
errors that weren't obvious in a scan of the code.  Fix these bugs.

Fixes: 530f9216 ("soc: qcom: ipa: AP/modem communications")
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 34fe5a1c

drivers/net/ipa/ipa_qmi_msg.c

+3 −3
Original line number Diff line number Diff line
@@ -119,7 +119,7 @@ struct qmi_elem_info ipa_driver_init_complete_rsp_ei[] = { 
			sizeof_field(struct ipa_driver_init_complete_rsp,

				     rsp),

		.tlv_type	= 0x02,

		.elem_size	= offsetof(struct ipa_driver_init_complete_rsp,

		.offset		= offsetof(struct ipa_driver_init_complete_rsp,

					   rsp),

		.ei_array	= qmi_response_type_v01_ei,

	},
@@ -137,7 +137,7 @@ struct qmi_elem_info ipa_init_complete_ind_ei[] = { 
			sizeof_field(struct ipa_init_complete_ind,

				     status),

		.tlv_type	= 0x02,

		.elem_size	= offsetof(struct ipa_init_complete_ind,

		.offset		= offsetof(struct ipa_init_complete_ind,

					   status),

		.ei_array	= qmi_response_type_v01_ei,

	},
@@ -218,7 +218,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = { 
			sizeof_field(struct ipa_init_modem_driver_req,

				     platform_type_valid),

		.tlv_type	= 0x10,

		.elem_size	= offsetof(struct ipa_init_modem_driver_req,

		.offset		= offsetof(struct ipa_init_modem_driver_req,

					   platform_type_valid),

	},

	{

CRA Git | Maintained and supported by SUSTech CRA and CCSE