Commit 743cb1ff authored Jul 29, 2014 by Peter Zijlstra Committed by Ingo Molnar Aug 12, 2014

sched/fair: Make calculate_imbalance() independent



Rik noticed that calculate_imbalance() relies on
update_sd_pick_busiest() to guarantee that busiest->sum_nr_running >
busiest->group_capacity_factor.

Break this implicit assumption (with the intent of not providing it
anymore) by having calculat_imbalance() verify it and not rely on
others.

Reported-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/20140729152631.GW12054@laptop.lan


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 98a96f20

kernel/sched/fair.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6248,7 +6248,7 @@ static inline void calculate_imbalance(struct lb_env env, struct sd_lb_stats s
		return fix_small_imbalance(env, sds);
		}

		if (!busiest->group_imb) {
		if (busiest->sum_nr_running > busiest->group_capacity_factor) {
		/*
		* Don't want to pull so many tasks that a group would go idle.
		* Except of course for the group_imb case, since then we might

Admin message