Commit 74347a99 authored by Tianyu Lan's avatar Tianyu Lan Committed by Wei Liu
Browse files

x86/Hyper-V: Unload vmbus channel in hv panic callback 



When kdump is not configured, a Hyper-V VM might still respond to
network traffic after a kernel panic when kernel parameter panic=0.
The panic CPU goes into an infinite loop with interrupts enabled,
and the VMbus driver interrupt handler still works because the
VMbus connection is unloaded only in the kdump path.  The network
responses make the other end of the connection think the VM is
still functional even though it has panic'ed, which could affect any
failover actions that should be taken.

Fix this by unloading the VMbus connection during the panic process.
vmbus_initiate_unload() could then be called twice (e.g., by
hyperv_panic_event() and hv_crash_handler(), so reset the connection
state in vmbus_initiate_unload() to ensure the unload is done only
once.

Fixes: 81b18bce ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic")
Reviewed-by: default avatarMichael Kelley <mikelley@microsoft.com>
Signed-off-by: default avatarTianyu Lan <Tianyu.Lan@microsoft.com>
Link: https://lore.kernel.org/r/20200406155331.2105-2-Tianyu.Lan@microsoft.com


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
parent 97d9f1c4

drivers/hv/channel_mgmt.c

+3 −0
Original line number Diff line number Diff line
@@ -839,6 +839,9 @@ void vmbus_initiate_unload(bool crash) 
{

	struct vmbus_channel_message_header hdr;



	if (xchg(&vmbus_connection.conn_state, DISCONNECTED) == DISCONNECTED)

		return;



	/* Pre-Win2012R2 hosts don't support reconnect */

	if (vmbus_proto_version < VERSION_WIN8_1)

		return;

drivers/hv/vmbus_drv.c

+13 −8
Original line number Diff line number Diff line
@@ -53,9 +53,12 @@ static int hyperv_panic_event(struct notifier_block *nb, unsigned long val, 
{

	struct pt_regs *regs;



	regs = current_pt_regs();

	vmbus_initiate_unload(true);



	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {

		regs = current_pt_regs();

		hyperv_report_panic(regs, val);

	}

	return NOTIFY_DONE;

}
@@ -1391,9 +1394,15 @@ static int vmbus_bus_init(void) 
		}



		register_die_notifier(&hyperv_die_block);

	}



	/*

	 * Always register the panic notifier because we need to unload

	 * the VMbus channel connection to prevent any VMbus

	 * activity after the VM panics.

	 */

	atomic_notifier_chain_register(&panic_notifier_list,

			       &hyperv_panic_block);

	}



	vmbus_request_offers();
@@ -2204,8 +2213,6 @@ static int vmbus_bus_suspend(struct device *dev) 


	vmbus_initiate_unload(false);



	vmbus_connection.conn_state = DISCONNECTED;



	/* Reset the event for the next resume. */

	reinit_completion(&vmbus_connection.ready_for_resume_event);
@@ -2289,7 +2296,6 @@ static void hv_kexec_handler(void) 
{

	hv_stimer_global_cleanup();

	vmbus_initiate_unload(false);

	vmbus_connection.conn_state = DISCONNECTED;

	/* Make sure conn_state is set as hv_synic_cleanup checks for it */

	mb();

	cpuhp_remove_state(hyperv_cpuhp_online);
@@ -2306,7 +2312,6 @@ static void hv_crash_handler(struct pt_regs *regs) 
	 * doing the cleanup for current CPU only. This should be sufficient

	 * for kdump.

	 */

	vmbus_connection.conn_state = DISCONNECTED;

	cpu = smp_processor_id();

	hv_stimer_cleanup(cpu);

	hv_synic_disable_regs(cpu);

CRA Git | Maintained and supported by SUSTech CRA and CCSE