Commit 742b11a7 authored Apr 05, 2009 by Latchesar Ionkov Committed by Eric Van Hensbergen Apr 05, 2009

net/9p: return error when p9_client_stat fails



p9_client_stat function doesn't return correct value if it fails.
p9_client_stat should return ERR_PTR of the error value when it fails.
Instead, it always returns a value to the allocated p9_wstat struct even
when it is not populated correctly.

This patch makes p9_client_stat to handle failure correctly.

Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Reviewed-by: Eric Van Hensbergen <ericvh@gmail.com>

parent 453ed90d

net/9p/client.c

+5 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1244,10 +1244,14 @@ struct p9_wstat p9_client_stat(struct p9_fid fid)
	ret->name, ret->uid, ret->gid, ret->muid, ret->extension,		ret->name, ret->uid, ret->gid, ret->muid, ret->extension,
	ret->n_uid, ret->n_gid, ret->n_muid);		ret->n_uid, ret->n_gid, ret->n_muid);

			p9_free_req(clnt, req);
			return ret;

	free_and_error:		free_and_error:
	p9_free_req(clnt, req);		p9_free_req(clnt, req);
	error:		error:
	return ret;		kfree(ret);
			return ERR_PTR(err);
	}		}
	EXPORT_SYMBOL(p9_client_stat);		EXPORT_SYMBOL(p9_client_stat);

Admin message