Commit 74181295 authored by Mike Frysinger's avatar Mike Frysinger
Browse files

Blackfin: allow cache funcs to be in L1 for IFLUSH Anomaly 05000491 



Anomaly 05000491 says that IFLUSH cannot have certain types of memory
stalls triggered before it has completed in order to function correctly.
One such condition is that it be in L1 instruction.  So add a config
option to move it there, default it to on, and throw up a warning when
it is turned off and this anomaly exists.

Since the anomaly should be worked around, we can drop the older method
of calling IFLUSH multiple times.

Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarSonic Zhang <sonic.zhang@analog.com>
parent dc7101bb

arch/blackfin/Kconfig

+12 −0
Original line number Diff line number Diff line
@@ -853,6 +853,18 @@ config CPLB_SWITCH_TAB_L1 
	  If enabled, the CPLB Switch Tables are linked

	  into L1 data memory. (less latency)



config CACHE_FLUSH_L1

	bool "Locate cache flush funcs in L1 Inst Memory"

	default y

	help

	  If enabled, the Blackfin cache flushing functions are linked

	  into L1 instruction memory.



	  Note that this might be required to address anomalies, but

	  these functions are pretty small, so it shouldn't be too bad.

	  If you are using a processor affected by an anomaly, the build

	  system will double check for you and prevent it.



config APP_STACK_L1

	bool "Support locating application stack in L1 Scratch Memory"

	default y

arch/blackfin/mach-common/arch_checks.c

+4 −0
Original line number Diff line number Diff line
@@ -60,3 +60,7 @@ 
	(defined(CONFIG_BFIN_EXTMEM_WRITEBACK) || defined(CONFIG_BFIN_L2_WRITEBACK))

# error "Anomaly 05000220 does not allow you to use Write Back cache with L2 or External Memory"

#endif



#if ANOMALY_05000491 && !defined(CONFIG_CACHE_FLUSH_L1)

# error You need IFLUSH in L1 inst while Anomaly 05000491 applies

#endif

arch/blackfin/mach-common/cache.S

+4 −11
Original line number Diff line number Diff line
@@ -11,7 +11,11 @@ 
#include <asm/cache.h>

#include <asm/page.h>



#ifdef CONFIG_CACHE_FLUSH_L1

.section .l1.text

#else

.text

#endif



/* 05000443 - IFLUSH cannot be last instruction in hardware loop */

#if ANOMALY_05000443
@@ -64,17 +68,6 @@ 


/* Invalidate all instruction cache lines assocoiated with this memory area */

ENTRY(_blackfin_icache_flush_range)

/*

 * Walkaround to avoid loading wrong instruction after invalidating icache

 * and following sequence is met.

 *

 * 1) One instruction address is cached in the instruction cache.

 * 2) This instruction in SDRAM is changed.

 * 3) IFLASH[P0] is executed only once in blackfin_icache_flush_range().

 * 4) This instruction is executed again, but the old one is loaded.

 */

	P0 = R0;

	IFLUSH[P0];

	do_flush IFLUSH

ENDPROC(_blackfin_icache_flush_range)

CRA Git | Maintained and supported by SUSTech CRA and CCSE