Commit 740f5b08 authored Feb 11, 2016 by Andrzej Hajda Committed by Linus Walleij Feb 16, 2016

pinctrl: mediatek: fix handling return value of mtk_pmx_find_gpio_mode



The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using coccinelle semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci.

Fixes: 59ee9c96 ('pinctrl: mediatek: Add gpio_request_enable support')
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 337ea0fb

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -753,7 +753,7 @@ static int mtk_pmx_gpio_request_enable(struct pinctrl_dev *pctldev,
		struct pinctrl_gpio_range *range,
		unsigned offset)
		{
		unsigned long muxval;
		int muxval;
		struct mtk_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);

		muxval = mtk_pmx_find_gpio_mode(pctl, offset);

Admin message