mfd: cs5535-mfd: Add missing line spacing and make local array static (740c1989) · Commits · 戴 / test

WARNING: Missing a blank line after declarations + struct resource *res; + res = platform_get_resource(pdev, IORESOURCE_IO, 0); WARNING: char * array declaration might be better as static const + const char *acpi_clones[] = { "olpc-xo1-pm-acpi", "olpc-xo1-sci-acpi" }; total: 0 errors, 2 warnings, 192 lines checked Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/cs5535-mfd.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -60,6 +60,7 @@ static int cs5535_mfd_res_enable(struct platform_device *pdev)
		static int cs5535_mfd_res_disable(struct platform_device *pdev)
		{
		struct resource *res;

		res = platform_get_resource(pdev, IORESOURCE_IO, 0);
		if (!res) {
		dev_err(&pdev->dev, "can't fetch device resource info\n");
		@@ -114,7 +115,10 @@ static struct mfd_cell cs5535_mfd_cells[] = {
		#ifdef CONFIG_OLPC
		static void cs5535_clone_olpc_cells(void)
		{
		const char *acpi_clones[] = { "olpc-xo1-pm-acpi", "olpc-xo1-sci-acpi" };
		static const char *acpi_clones[] = {
		"olpc-xo1-pm-acpi",
		"olpc-xo1-sci-acpi"
		};

		if (!machine_is_olpc())
		return;

Admin message