Commit 73c994e4 authored Jul 10, 2010 by Tobias Lorenz Committed by Mauro Carvalho Chehab Aug 02, 2010

V4L/DVB: si470x: -EINVAL overwritten in si470x_vidioc_s_tuner()

This patch to the si470x_vidioc_s_tuner function was developed in
cooperation with Roel Kluin <roel.kluin@gmail.com>. It sets the default
retval to 0 instead of -EINVAL, identical to what is done in all other
set/get functions of v4l2_ioctl_ops. This is just as cosmetic change, as
retval is directly overwritten by the si470x_disconnect_check() anyway.

Signed-off-by: Tobias Lorenz <tobias.lorenz@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 22b0766b

drivers/media/radio/si470x/radio-si470x-common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -748,7 +748,7 @@ static int si470x_vidioc_s_tuner(struct file file, void priv,
		struct v4l2_tuner *tuner)
		{
		struct si470x_device *radio = video_drvdata(file);
		int retval = -EINVAL;
		int retval = 0;

		/* safety checks */
		retval = si470x_disconnect_check(radio);

Admin message