Commit 73a75b96 authored by Leon Romanovsky's avatar Leon Romanovsky
Browse files

net/mlx5: Remove empty QP and CQ events handlers 



The QP and CQ events functions do nothing except printing some debug
messages. There is nothing to do with this knowledge and such events,
so remove them.

Reviewed-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
parent ec44e72b

drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c

+0 −19
Original line number Diff line number Diff line
@@ -362,23 +362,6 @@ static void mlx5_fpga_conn_arm_cq(struct mlx5_fpga_conn *conn) 
		    conn->fdev->conn_res.uar->map, conn->cq.wq.cc);

}



static void mlx5_fpga_conn_cq_event(struct mlx5_core_cq *mcq,

				    enum mlx5_event event)

{

	struct mlx5_fpga_conn *conn;



	conn = container_of(mcq, struct mlx5_fpga_conn, cq.mcq);

	mlx5_fpga_warn(conn->fdev, "CQ event %u on CQ #%u\n", event, mcq->cqn);

}



static void mlx5_fpga_conn_event(struct mlx5_core_qp *mqp, int event)

{

	struct mlx5_fpga_conn *conn;



	conn = container_of(mqp, struct mlx5_fpga_conn, qp.mqp);

	mlx5_fpga_warn(conn->fdev, "QP event %u on QP #%u\n", event, mqp->qpn);

}



static inline void mlx5_fpga_conn_cqes(struct mlx5_fpga_conn *conn,

				       unsigned int budget)

{
@@ -493,7 +476,6 @@ static int mlx5_fpga_conn_create_cq(struct mlx5_fpga_conn *conn, int cq_size) 
	*conn->cq.mcq.arm_db    = 0;

	conn->cq.mcq.vector     = 0;

	conn->cq.mcq.comp       = mlx5_fpga_conn_cq_complete;

	conn->cq.mcq.event      = mlx5_fpga_conn_cq_event;

	conn->cq.mcq.irqn       = irqn;

	conn->cq.mcq.uar        = fdev->conn_res.uar;

	tasklet_init(&conn->cq.tasklet, mlx5_fpga_conn_cq_tasklet,
@@ -607,7 +589,6 @@ static int mlx5_fpga_conn_create_qp(struct mlx5_fpga_conn *conn, 
		goto err_sq_bufs;



	conn->qp.mqp.qpn = MLX5_GET(create_qp_out, out, qpn);

	conn->qp.mqp.event = mlx5_fpga_conn_event;

	mlx5_fpga_dbg(fdev, "Created QP #0x%x\n", conn->qp.mqp.qpn);



	goto out;

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c

+0 −14
Original line number Diff line number Diff line
@@ -100,11 +100,6 @@ static int dr_poll_cq(struct mlx5dr_cq *dr_cq, int ne) 
	return err == CQ_POLL_ERR ? err : npolled;

}



static void dr_qp_event(struct mlx5_core_qp *mqp, int event)

{

	pr_info("DR QP event %u on QP #%u\n", event, mqp->qpn);

}



static struct mlx5dr_qp *dr_create_rc_qp(struct mlx5_core_dev *mdev,

					 struct dr_qp_init_attr *attr)

{
@@ -187,7 +182,6 @@ static struct mlx5dr_qp *dr_create_rc_qp(struct mlx5_core_dev *mdev, 
	kfree(in);

	if (err)

		goto err_in;

	dr_qp->mqp.event = dr_qp_event;

	dr_qp->uar = attr->uar;



	return dr_qp;
@@ -695,12 +689,6 @@ static int dr_prepare_qp_to_rts(struct mlx5dr_domain *dmn) 
	return 0;

}



static void dr_cq_event(struct mlx5_core_cq *mcq,

			enum mlx5_event event)

{

	pr_info("CQ event %u on CQ #%u\n", event, mcq->cqn);

}



static struct mlx5dr_cq *dr_create_cq(struct mlx5_core_dev *mdev,

				      struct mlx5_uars_page *uar,

				      size_t ncqe)
@@ -761,8 +749,6 @@ static struct mlx5dr_cq *dr_create_cq(struct mlx5_core_dev *mdev, 
	pas = (__be64 *)MLX5_ADDR_OF(create_cq_in, in, pas);

	mlx5_fill_page_frag_array(&cq->wq_ctrl.buf, pas);



	cq->mcq.event = dr_cq_event;



	err = mlx5_core_create_cq(mdev, &cq->mcq, in, inlen, out, sizeof(out));

	kvfree(in);

CRA Git | Maintained and supported by SUSTech CRA and CCSE