Commit 73a02d32 authored by Rahul Pathak's avatar Rahul Pathak Committed by Greg Kroah-Hartman
Browse files

usb: Use memdup_user to reuse the code 



Fixing coccicheck warning which recommends to use memdup_user instead
to reimplement its code, using memdup_user simplifies the code

./drivers/usb/core/devio.c:1398:11-18: WARNING opportunity for memdup_user

Signed-off-by: default avatarRahul Pathak <rpathak@visteon.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 64f10edf

drivers/usb/core/devio.c

+4 −5
Original line number Diff line number Diff line
@@ -1378,11 +1378,10 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb 
		number_of_packets = uurb->number_of_packets;

		isofrmlen = sizeof(struct usbdevfs_iso_packet_desc) *

				   number_of_packets;

		isopkt = kmalloc(isofrmlen, GFP_KERNEL);

		if (!isopkt)

			return -ENOMEM;

		if (copy_from_user(isopkt, iso_frame_desc, isofrmlen)) {

			ret = -EFAULT;

		isopkt = memdup_user(iso_frame_desc, isofrmlen);

		if (IS_ERR(isopkt)) {

			ret = PTR_ERR(isopkt);

			isopkt = NULL;

			goto error;

		}

		for (totlen = u = 0; u < number_of_packets; u++) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE