Commit 739e6f59 authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: provide lockdep keys for nested/unnested irqchips 



The helper function for adding a GPIO chip compiles in a lockdep
key for debugging, the same key is needed for nested chips as
well.

The macro construction is unreadable, replace this with two
static inlines instead.

The _gpiochip_irqchip_add prefixed function is not helpful,
rename it with gpiochip_irqchip_add_key() that tell us what the
function is actually doing.

Fixes: d245b3f9 ("gpio: simplify adding threaded interrupts")
Cc: Roger Quadros <rogerq@ti.com>
Reported-by: default avatarClemens Gruber <clemens.gruber@pqgruber.com>
Reported-by: default avatarRoger Quadros <rogerq@ti.com>
Reported-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
Tested-by: default avatarClemens Gruber <clemens.gruber@pqgruber.com>
Tested-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 49def185

drivers/gpio/gpiolib.c

+9 −9
Original line number Diff line number Diff line
@@ -1723,7 +1723,7 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip) 
}



/**

 * _gpiochip_irqchip_add() - adds an irqchip to a gpiochip

 * gpiochip_irqchip_add_key() - adds an irqchip to a gpiochip

 * @gpiochip: the gpiochip to add the irqchip to

 * @irqchip: the irqchip to add to the gpiochip

 * @first_irq: if not dynamically assigned, the base (first) IRQ to
@@ -1749,7 +1749,7 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip) 
 * the pins on the gpiochip can generate a unique IRQ. Everything else

 * need to be open coded.

 */

int _gpiochip_irqchip_add(struct gpio_chip *gpiochip,

int gpiochip_irqchip_add_key(struct gpio_chip *gpiochip,

			     struct irq_chip *irqchip,

			     unsigned int first_irq,

			     irq_flow_handler_t handler,
@@ -1840,7 +1840,7 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip, 


	return 0;

}

EXPORT_SYMBOL_GPL(_gpiochip_irqchip_add);

EXPORT_SYMBOL_GPL(gpiochip_irqchip_add_key);



#else /* CONFIG_GPIOLIB_IRQCHIP */

include/linux/gpio/driver.h

+50 −20
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ void gpiochip_set_nested_irqchip(struct gpio_chip *gpiochip, 
		struct irq_chip *irqchip,

		int parent_irq);



int _gpiochip_irqchip_add(struct gpio_chip *gpiochip,

int gpiochip_irqchip_add_key(struct gpio_chip *gpiochip,

			     struct irq_chip *irqchip,

			     unsigned int first_irq,

			     irq_flow_handler_t handler,
@@ -282,29 +282,59 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip, 
			     bool nested,

			     struct lock_class_key *lock_key);



/* FIXME: I assume threaded IRQchips do not have the lockdep problem */

static inline int gpiochip_irqchip_add_nested(struct gpio_chip *gpiochip,

#ifdef CONFIG_LOCKDEP



/*

 * Lockdep requires that each irqchip instance be created with a

 * unique key so as to avoid unnecessary warnings. This upfront

 * boilerplate static inlines provides such a key for each

 * unique instance.

 */

static inline int gpiochip_irqchip_add(struct gpio_chip *gpiochip,

				       struct irq_chip *irqchip,

				       unsigned int first_irq,

				       irq_flow_handler_t handler,

				       unsigned int type)

{

	return _gpiochip_irqchip_add(gpiochip, irqchip, first_irq,

				     handler, type, true, NULL);

	static struct lock_class_key key;



	return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,

					handler, type, false, &key);

}



#ifdef CONFIG_LOCKDEP

#define gpiochip_irqchip_add(...)				\

(								\

	({							\

		static struct lock_class_key _key;		\

		_gpiochip_irqchip_add(__VA_ARGS__, false, &_key); \

	})							\

)

static inline int gpiochip_irqchip_add_nested(struct gpio_chip *gpiochip,

			  struct irq_chip *irqchip,

			  unsigned int first_irq,

			  irq_flow_handler_t handler,

			  unsigned int type)

{



	static struct lock_class_key key;



	return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,

					handler, type, true, &key);

}

#else

#define gpiochip_irqchip_add(...)				\

	_gpiochip_irqchip_add(__VA_ARGS__, false, NULL)

#endif

static inline int gpiochip_irqchip_add(struct gpio_chip *gpiochip,

				       struct irq_chip *irqchip,

				       unsigned int first_irq,

				       irq_flow_handler_t handler,

				       unsigned int type)

{

	return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,

					handler, type, false, NULL);

}



static inline int gpiochip_irqchip_add_nested(struct gpio_chip *gpiochip,

			  struct irq_chip *irqchip,

			  unsigned int first_irq,

			  irq_flow_handler_t handler,

			  unsigned int type)

{

	return gpiochip_irqchip_add_key(gpiochip, irqchip, first_irq,

					handler, type, true, NULL);

}

#endif /* CONFIG_LOCKDEP */



#endif /* CONFIG_GPIOLIB_IRQCHIP */

CRA Git | Maintained and supported by SUSTech CRA and CCSE