Commit 7390bec4 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: r9701: stop setting a default time 



It doesn't make sense to set the RTC to a default value at probe time. Let
the core handle invalid date and time.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-2-alexandre.belloni@bootlin.com
parent 92c6dcfb

drivers/rtc/rtc-r9701.c

+0 −22
Original line number Diff line number Diff line
@@ -115,7 +115,6 @@ static const struct rtc_class_ops r9701_rtc_ops = { 
static int r9701_probe(struct spi_device *spi)

{

	struct rtc_device *rtc;

	struct rtc_time dt;

	unsigned char tmp;

	int res;
@@ -126,27 +125,6 @@ static int r9701_probe(struct spi_device *spi) 
		return -ENODEV;

	}



	/*

	 * The device seems to be present. Now check if the registers

	 * contain invalid values. If so, try to write a default date:

	 * 2000/1/1 00:00:00

	 */

	if (r9701_get_datetime(&spi->dev, &dt)) {

		dev_info(&spi->dev, "trying to repair invalid date/time\n");

		dt.tm_sec  = 0;

		dt.tm_min  = 0;

		dt.tm_hour = 0;

		dt.tm_mday = 1;

		dt.tm_mon  = 0;

		dt.tm_year = 100;



		if (r9701_set_datetime(&spi->dev, &dt) ||

				r9701_get_datetime(&spi->dev, &dt)) {

			dev_err(&spi->dev, "cannot repair RTC register\n");

			return -ENODEV;

		}

	}



	rtc = devm_rtc_device_register(&spi->dev, "r9701",

				&r9701_rtc_ops, THIS_MODULE);

	if (IS_ERR(rtc))

CRA Git | Maintained and supported by SUSTech CRA and CCSE