Commit 73896f60 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Rob Herring
Browse files

drm/panfrost: Prefix interrupt handlers' names 



Currently, the interrupt lines requested by Panfrost
use unmeaningful names, which adds some obscurity
to interrupt introspection (i.e. any tool based
on procfs' interrupts file).

In order to improve this, prefix each requested
interrupt with the module name: panfrost-{gpu,job,mmu}.

Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Reviewed-by: default avatarAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191214045952.9452-1-ezequiel@collabora.com
parent a5f76823

drivers/gpu/drm/panfrost/panfrost_gpu.c

+1 −1
Original line number Diff line number Diff line
@@ -346,7 +346,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) 
		return -ENODEV;



	err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,

			       IRQF_SHARED, "gpu", pfdev);

			       IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);

	if (err) {

		dev_err(pfdev->dev, "failed to request gpu irq");

		return err;

drivers/gpu/drm/panfrost/panfrost_job.c

+1 −1
Original line number Diff line number Diff line
@@ -496,7 +496,7 @@ int panfrost_job_init(struct panfrost_device *pfdev) 
		return -ENODEV;



	ret = devm_request_irq(pfdev->dev, irq, panfrost_job_irq_handler,

			       IRQF_SHARED, "job", pfdev);

			       IRQF_SHARED, KBUILD_MODNAME "-job", pfdev);

	if (ret) {

		dev_err(pfdev->dev, "failed to request job irq");

		return ret;

drivers/gpu/drm/panfrost/panfrost_mmu.c

+4 −2
Original line number Diff line number Diff line
@@ -632,9 +632,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev) 
	if (irq <= 0)

		return -ENODEV;



	err = devm_request_threaded_irq(pfdev->dev, irq, panfrost_mmu_irq_handler,

	err = devm_request_threaded_irq(pfdev->dev, irq,

					panfrost_mmu_irq_handler,

					panfrost_mmu_irq_handler_thread,

					IRQF_SHARED, "mmu", pfdev);

					IRQF_SHARED, KBUILD_MODNAME "-mmu",

					pfdev);



	if (err) {

		dev_err(pfdev->dev, "failed to request mmu irq");

CRA Git | Maintained and supported by SUSTech CRA and CCSE