Commit 7386199c authored Oct 11, 2012 by Jonathan Brassow Committed by NeilBrown Oct 11, 2012

DM RAID: Fix comparison of index and quantity for "rebuild" parameter



DM RAID: Fix comparison of index and quantity for "rebuild" parameter

The "rebuild" parameter takes an index argument that starts counting from
zero.  The conditional used to validate the index was using '>' rather than
'>=', leaving the door open for an index value that would be 1 too large.

Reported-by: Neil Brown <neilb@suse.de>
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>

parent 4ec1e369

drivers/md/dm-raid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -539,7 +539,7 @@ static int parse_raid_params(struct raid_set rs, char *argv,

		/* Parameters that take a numeric value are checked here */
		if (!strcasecmp(key, "rebuild")) {
		if (value > rs->md.raid_disks) {
		if (value >= rs->md.raid_disks) {
		rs->ti->error = "Invalid rebuild index given";
		return -EINVAL;
		}

Admin message