Commit 73727f4d authored by Petr Mladek's avatar Petr Mladek
Browse files

livepatch: Basic API to track system state changes 

This is another step how to help maintaining more livepatches.

One big help was the atomic replace and cumulative livepatches. These
livepatches replace the already installed ones. Therefore it should
be enough when each cumulative livepatch is consistent.

The problems might come with shadow variables and callbacks. They might
change the system behavior or state so that it is no longer safe to
go back and use an older livepatch or the original kernel code. Also,
a new livepatch must be able to detect changes which were made by
the already installed livepatches.

This is where the livepatch system state tracking gets useful. It
allows to:

  - find whether a system state has already been modified by
    previous livepatches

  - store data needed to manipulate and restore the system state

The information about the manipulated system states is stored in an
array of struct klp_state. It can be searched by two new functions
klp_get_state() and klp_get_prev_state().

The dependencies are going to be solved by a version field added later.
The only important information is that it will be allowed to modify
the same state by more non-cumulative livepatches. It is similar
to allowing to modify the same function several times. The livepatch
author is responsible for preventing incompatible changes.

Link: http://lkml.kernel.org/r/20191030154313.13263-3-pmladek@suse.com


To: Jiri Kosina <jikos@kernel.org>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Nicolai Stange <nstange@suse.de>
Cc: live-patching@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Acked-by: default avatarMiroslav Benes <mbenes@suse.cz>
Acked-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 7e35e4eb

include/linux/livepatch.h

+15 −0
Original line number Diff line number Diff line
@@ -130,10 +130,21 @@ struct klp_object { 
	bool patched;

};



/**

 * struct klp_state - state of the system modified by the livepatch

 * @id:		system state identifier (non-zero)

 * @data:	custom data

 */

struct klp_state {

	unsigned long id;

	void *data;

};



/**

 * struct klp_patch - patch structure for live patching

 * @mod:	reference to the live patch module

 * @objs:	object entries for kernel objects to be patched

 * @states:	system states that can get modified

 * @replace:	replace all actively used patches

 * @list:	list node for global list of actively used patches

 * @kobj:	kobject for sysfs resources
@@ -147,6 +158,7 @@ struct klp_patch { 
	/* external */

	struct module *mod;

	struct klp_object *objs;

	struct klp_state *states;

	bool replace;



	/* internal */
@@ -217,6 +229,9 @@ void *klp_shadow_get_or_alloc(void *obj, unsigned long id, 
void klp_shadow_free(void *obj, unsigned long id, klp_shadow_dtor_t dtor);

void klp_shadow_free_all(unsigned long id, klp_shadow_dtor_t dtor);



struct klp_state *klp_get_state(struct klp_patch *patch, unsigned long id);

struct klp_state *klp_get_prev_state(unsigned long id);



#else /* !CONFIG_LIVEPATCH */



static inline int klp_module_coming(struct module *mod) { return 0; }

kernel/livepatch/Makefile

+1 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

obj-$(CONFIG_LIVEPATCH) += livepatch.o



livepatch-objs := core.o patch.o shadow.o transition.o
 
livepatch-objs := core.o patch.o shadow.o state.o transition.o

kernel/livepatch/state.c

0 → 100644
+83 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-or-later

/*

 * system_state.c - State of the system modified by livepatches

 *

 * Copyright (C) 2019 SUSE

 */



#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt



#include <linux/livepatch.h>

#include "core.h"

#include "transition.h"



#define klp_for_each_state(patch, state)		\

	for (state = patch->states; state && state->id; state++)



/**

 * klp_get_state() - get information about system state modified by

 *	the given patch

 * @patch:	livepatch that modifies the given system state

 * @id:		custom identifier of the modified system state

 *

 * Checks whether the given patch modifies the given system state.

 *

 * The function can be called either from pre/post (un)patch

 * callbacks or from the kernel code added by the livepatch.

 *

 * Return: pointer to struct klp_state when found, otherwise NULL.

 */

struct klp_state *klp_get_state(struct klp_patch *patch, unsigned long id)

{

	struct klp_state *state;



	klp_for_each_state(patch, state) {

		if (state->id == id)

			return state;

	}



	return NULL;

}

EXPORT_SYMBOL_GPL(klp_get_state);



/**

 * klp_get_prev_state() - get information about system state modified by

 *	the already installed livepatches

 * @id:		custom identifier of the modified system state

 *

 * Checks whether already installed livepatches modify the given

 * system state.

 *

 * The same system state can be modified by more non-cumulative

 * livepatches. It is expected that the latest livepatch has

 * the most up-to-date information.

 *

 * The function can be called only during transition when a new

 * livepatch is being enabled or when such a transition is reverted.

 * It is typically called only from from pre/post (un)patch

 * callbacks.

 *

 * Return: pointer to the latest struct klp_state from already

 *	installed livepatches, NULL when not found.

 */

struct klp_state *klp_get_prev_state(unsigned long id)

{

	struct klp_patch *patch;

	struct klp_state *state, *last_state = NULL;



	if (WARN_ON_ONCE(!klp_transition_patch))

		return NULL;



	klp_for_each_patch(patch) {

		if (patch == klp_transition_patch)

			goto out;



		state = klp_get_state(patch, id);

		if (state)

			last_state = state;

	}



out:

	return last_state;

}

EXPORT_SYMBOL_GPL(klp_get_prev_state);

CRA Git | Maintained and supported by SUSTech CRA and CCSE