Commit 73575938 authored Jan 07, 2011 by Richard Genoud Committed by Grant Likely Jan 07, 2011

spi/imx: correct the test on platform_get_irq() return value



The test "if (spi_imx->irq <= 0)" is not testing the IRQ value, but
the return value of platform_get_irq().  As platform_get_irq() can
return an error (-ENXIO) or the IRQ value it found, the test should be
"if (spi_imx->irq < 0)"

[grant.likely: Note: In general, Linux irq number 0 should also mean
no irq, but arm still allows devices to be assigned 0, and the imx
platform uses 0 for one of the spi devices, so this patch is needed
for the device to work]

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

parent 77e58efd

drivers/spi/spi_imx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -821,7 +821,7 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
		}

		spi_imx->irq = platform_get_irq(pdev, 0);
		if (spi_imx->irq <= 0) {
		if (spi_imx->irq < 0) {
		ret = -EINVAL;
		goto out_iounmap;
		}

Admin message