Commit 732375c6 authored by Dima Zavin's avatar Dima Zavin Committed by Ingo Molnar
Browse files

plist: Remove the need to supply locks to plist heads 



This was legacy code brought over from the RT tree and
is no longer necessary.

Signed-off-by: default avatarDima Zavin <dima@android.com>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Daniel Walker <dwalker@codeaurora.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Link: http://lkml.kernel.org/r/1310084879-10351-2-git-send-email-dima@android.com


Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 8edbb83e

include/linux/plist.h

+3 −52
Original line number Diff line number Diff line
@@ -77,14 +77,9 @@ 


#include <linux/kernel.h>

#include <linux/list.h>

#include <linux/spinlock_types.h>



struct plist_head {

	struct list_head node_list;

#ifdef CONFIG_DEBUG_PI_LIST

	raw_spinlock_t *rawlock;

	spinlock_t *spinlock;

#endif

};



struct plist_node {
@@ -93,37 +88,13 @@ struct plist_node { 
	struct list_head	node_list;

};



#ifdef CONFIG_DEBUG_PI_LIST

# define PLIST_HEAD_LOCK_INIT(_lock)		.spinlock = _lock

# define PLIST_HEAD_LOCK_INIT_RAW(_lock)	.rawlock = _lock

#else

# define PLIST_HEAD_LOCK_INIT(_lock)

# define PLIST_HEAD_LOCK_INIT_RAW(_lock)

#endif



#define _PLIST_HEAD_INIT(head)				\

	.node_list = LIST_HEAD_INIT((head).node_list)



/**

 * PLIST_HEAD_INIT - static struct plist_head initializer

 * @head:	struct plist_head variable name

 * @_lock:	lock to initialize for this list

 */

#define PLIST_HEAD_INIT(head, _lock)			\

{							\

	_PLIST_HEAD_INIT(head),				\

	PLIST_HEAD_LOCK_INIT(&(_lock))			\

}



/**

 * PLIST_HEAD_INIT_RAW - static struct plist_head initializer

 * @head:	struct plist_head variable name

 * @_lock:	lock to initialize for this list

 */

#define PLIST_HEAD_INIT_RAW(head, _lock)		\

#define PLIST_HEAD_INIT(head)				\

{							\

	_PLIST_HEAD_INIT(head),				\

	PLIST_HEAD_LOCK_INIT_RAW(&(_lock))		\

	.node_list = LIST_HEAD_INIT((head).node_list)	\

}



/**
@@ -141,31 +112,11 @@ struct plist_node { 
/**

 * plist_head_init - dynamic struct plist_head initializer

 * @head:	&struct plist_head pointer

 * @lock:	spinlock protecting the list (debugging)

 */

static inline void

plist_head_init(struct plist_head *head, spinlock_t *lock)

plist_head_init(struct plist_head *head)

{

	INIT_LIST_HEAD(&head->node_list);

#ifdef CONFIG_DEBUG_PI_LIST

	head->spinlock = lock;

	head->rawlock = NULL;

#endif

}



/**

 * plist_head_init_raw - dynamic struct plist_head initializer

 * @head:	&struct plist_head pointer

 * @lock:	raw_spinlock protecting the list (debugging)

 */

static inline void

plist_head_init_raw(struct plist_head *head, raw_spinlock_t *lock)

{

	INIT_LIST_HEAD(&head->node_list);

#ifdef CONFIG_DEBUG_PI_LIST

	head->rawlock = lock;

	head->spinlock = NULL;

#endif

}



/**

include/linux/rtmutex.h

+2 −2
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ struct hrtimer_sleeper; 


#define __RT_MUTEX_INITIALIZER(mutexname) \

	{ .wait_lock = __RAW_SPIN_LOCK_UNLOCKED(mutexname.wait_lock) \

	, .wait_list = PLIST_HEAD_INIT_RAW(mutexname.wait_list, mutexname.wait_lock) \

	, .wait_list = PLIST_HEAD_INIT(mutexname.wait_list) \

	, .owner = NULL \

	__DEBUG_RT_MUTEX_INITIALIZER(mutexname)}
@@ -100,7 +100,7 @@ extern void rt_mutex_unlock(struct rt_mutex *lock); 


#ifdef CONFIG_RT_MUTEXES

# define INIT_RT_MUTEXES(tsk)						\

	.pi_waiters	= PLIST_HEAD_INIT(tsk.pi_waiters, tsk.pi_lock),	\

	.pi_waiters	= PLIST_HEAD_INIT(tsk.pi_waiters),	\

	INIT_RT_MUTEX_DEBUG(tsk)

#else

# define INIT_RT_MUTEXES(tsk)

kernel/fork.c

+1 −1
Original line number Diff line number Diff line
@@ -1013,7 +1013,7 @@ static void rt_mutex_init_task(struct task_struct *p) 
{

	raw_spin_lock_init(&p->pi_lock);

#ifdef CONFIG_RT_MUTEXES

	plist_head_init_raw(&p->pi_waiters, &p->pi_lock);

	plist_head_init(&p->pi_waiters);

	p->pi_blocked_on = NULL;

#endif

}

kernel/futex.c

+1 −1
Original line number Diff line number Diff line
@@ -2697,7 +2697,7 @@ static int __init futex_init(void) 
		futex_cmpxchg_enabled = 1;



	for (i = 0; i < ARRAY_SIZE(futex_queues); i++) {

		plist_head_init(&futex_queues[i].chain, &futex_queues[i].lock);

		plist_head_init(&futex_queues[i].chain);

		spin_lock_init(&futex_queues[i].lock);

	}

kernel/pm_qos_params.c

+3 −3
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ static DEFINE_SPINLOCK(pm_qos_lock); 
static struct pm_qos_object null_pm_qos;

static BLOCKING_NOTIFIER_HEAD(cpu_dma_lat_notifier);

static struct pm_qos_object cpu_dma_pm_qos = {

	.requests = PLIST_HEAD_INIT(cpu_dma_pm_qos.requests, pm_qos_lock),

	.requests = PLIST_HEAD_INIT(cpu_dma_pm_qos.requests),

	.notifiers = &cpu_dma_lat_notifier,

	.name = "cpu_dma_latency",

	.target_value = PM_QOS_CPU_DMA_LAT_DEFAULT_VALUE,
@@ -84,7 +84,7 @@ static struct pm_qos_object cpu_dma_pm_qos = { 


static BLOCKING_NOTIFIER_HEAD(network_lat_notifier);

static struct pm_qos_object network_lat_pm_qos = {

	.requests = PLIST_HEAD_INIT(network_lat_pm_qos.requests, pm_qos_lock),

	.requests = PLIST_HEAD_INIT(network_lat_pm_qos.requests),

	.notifiers = &network_lat_notifier,

	.name = "network_latency",

	.target_value = PM_QOS_NETWORK_LAT_DEFAULT_VALUE,
@@ -95,7 +95,7 @@ static struct pm_qos_object network_lat_pm_qos = { 


static BLOCKING_NOTIFIER_HEAD(network_throughput_notifier);

static struct pm_qos_object network_throughput_pm_qos = {

	.requests = PLIST_HEAD_INIT(network_throughput_pm_qos.requests, pm_qos_lock),

	.requests = PLIST_HEAD_INIT(network_throughput_pm_qos.requests),

	.notifiers = &network_throughput_notifier,

	.name = "network_throughput",

	.target_value = PM_QOS_NETWORK_THROUGHPUT_DEFAULT_VALUE,

CRA Git | Maintained and supported by SUSTech CRA and CCSE