checkpatch: ignore some octal permissions of 0 (73121534) · Commits · 戴 / test

module_param and create_proc uses with a permissions use of a single 0 are "special" and should not emit any warning. module_param uses with permission 0 are not visible in sysfs create_proc uses with permission 0 use a default permission Link: http://lkml.kernel.org/r/b6583611bb529ea6f6d43786827fddbabbab0a71.1513190059.git.joe@perches.com Signed-off-by:

scripts/checkpatch.pl

+7 −2

Original line number	Diff line number	Diff line
		@@ -6276,6 +6276,10 @@ sub process {

		# Mode permission misuses where it seems decimal should be octal
		# This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
		# o Ignore module_param*(...) uses with a decimal 0 permission as that has a
		# specific definition of not visible in sysfs.
		# o Ignore proc_create*(...) uses with a decimal 0 permission as that means
		# use the default permissions
		if ($^V && $^V ge 5.10.0 &&
		defined $stat &&
		$line =~ /$mode_perms_search/) {
		@@ -6299,8 +6303,9 @@ sub process {
		if ($stat =~ /$test/) {
		my $val = $1;
		$val = $6 if ($skip_args ne "");
		if (($val =~ /^$Int$/ && $val !~ /^$Octal$/) \|\|
		($val =~ /^$Octal$/ && length($val) ne 4)) {
		if (!($func =~ /^(?:module_param\|proc_create)/ && $val eq "0") &&
		(($val =~ /^$Int$/ && $val !~ /^$Octal$/) \|\|
		($val =~ /^$Octal$/ && length($val) ne 4))) {
		ERROR("NON_OCTAL_PERMISSIONS",
		"Use 4 digit octal (0777) not decimal permissions\n" . "$here\n" . $stat_real);
		}