net: drop_monitor: Use kstrdup (72d62c4e) · Commits · 戴 / test

Convert the equivalent but rather odd uses of kmemdup with __GFP_ZERO to the more common kstrdup and avoid unnecessary zeroing of copied over memory. Signed-off-by:

Joe Perches <joe@perches.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/core/drop_monitor.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -802,16 +802,12 @@ net_dm_hw_metadata_clone(const struct net_dm_hw_metadata *hw_metadata)
		if (!n_hw_metadata)
		return NULL;

		trap_group_name = kmemdup(hw_metadata->trap_group_name,
		strlen(hw_metadata->trap_group_name) + 1,
		GFP_ATOMIC \| __GFP_ZERO);
		trap_group_name = kstrdup(hw_metadata->trap_group_name, GFP_ATOMIC);
		if (!trap_group_name)
		goto free_hw_metadata;
		n_hw_metadata->trap_group_name = trap_group_name;

		trap_name = kmemdup(hw_metadata->trap_name,
		strlen(hw_metadata->trap_name) + 1,
		GFP_ATOMIC \| __GFP_ZERO);
		trap_name = kstrdup(hw_metadata->trap_name, GFP_ATOMIC);
		if (!trap_name)
		goto free_trap_group;
		n_hw_metadata->trap_name = trap_name;

Admin message