Commit 72b8ad40 authored Oct 18, 2018 by Liviu Dudau Committed by Jacek Anaszewski Oct 26, 2018

leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds



Commit 45d4c6de ("leds: gpio: Try to lookup gpiod from device")
removed the common code path that set the led_dat->gpiod pointer in
create_gpio_led(), but only added it back for the devices that have
a valid gpio_led_platform_data structure. Calling gpio_leds_create()
in gpio_led_probe() is not enough to get a valid gpiod pointer.

Fortunately enough, gpio_leds_create() already gets the needed pointer,
we just need to assign it to the relevant gpio_led_data structure.

Fixes: 45d4c6de ("leds: gpio: Try to lookup gpiod from device")
Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

parent 8dbac65f

drivers/leds/leds-gpio.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -163,6 +163,8 @@ static struct gpio_leds_priv gpio_leds_create(struct platform_device pdev)
		return ERR_CAST(led.gpiod);
		}

		led_dat->gpiod = led.gpiod;

		fwnode_property_read_string(child, "linux,default-trigger",
		&led.default_trigger);

Admin message