Commit 72b48682 authored May 28, 2020 by Roopa Prabhu Committed by David S. Miller May 30, 2020

vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID



NDA_NH_ID represents a remote ip or a group of remote ips.
It allows use of nexthop groups in lieu of a remote ip or a
list of remote ips supported by the fdb api.

Current code ignores the other remote ip attrs when NDA_NH_ID is
specified. In the spirit of strict checking, This commit adds a
check to explicitly return an error on incorrect usage.

Fixes: 1274e1cc ("vxlan: ecmp support for mac fdb entries")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d9f0d660

drivers/net/vxlan.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1196,6 +1196,10 @@ static int vxlan_fdb_parse(struct nlattr tb[], struct vxlan_dev vxlan,
		struct net *net = dev_net(vxlan->dev);
		int err;

		if (tb[NDA_NH_ID] && (tb[NDA_DST] \|\| tb[NDA_VNI] \|\| tb[NDA_IFINDEX] \|\|
		tb[NDA_PORT]))
		return -EINVAL;

		if (tb[NDA_DST]) {
		err = vxlan_nla_get_addr(ip, tb[NDA_DST]);
		if (err)

Admin message