Commit 72b16d4a authored by Vinod Koul's avatar Vinod Koul Committed by Greg Kroah-Hartman
Browse files

soundwire: avoid multiple assignments 



Modify the code to avoid multiple assignments by assigning to variable
after error checks in soundwire bus.

CHECK: multiple assignments should be avoided

Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1215daee

drivers/soundwire/bus.c

+4 −2
Original line number Diff line number Diff line
@@ -812,12 +812,13 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) 
	sdw_modify_slave_status(slave, SDW_SLAVE_ALERT);



	/* Read Instat 1, Instat 2 and Instat 3 registers */

	buf = ret = sdw_read(slave, SDW_SCP_INT1);

	ret = sdw_read(slave, SDW_SCP_INT1);

	if (ret < 0) {

		dev_err(slave->bus->dev,

			"SDW_SCP_INT1 read failed:%d\n", ret);

		return ret;

	}

	buf = ret;



	ret = sdw_nread(slave, SDW_SCP_INTSTAT2, 2, buf2);

	if (ret < 0) {
@@ -910,12 +911,13 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) 
		 * Read status again to ensure no new interrupts arrived

		 * while servicing interrupts.

		 */

		_buf = ret = sdw_read(slave, SDW_SCP_INT1);

		ret = sdw_read(slave, SDW_SCP_INT1);

		if (ret < 0) {

			dev_err(slave->bus->dev,

				"SDW_SCP_INT1 read failed:%d\n", ret);

			return ret;

		}

		_buf = ret;



		ret = sdw_nread(slave, SDW_SCP_INTSTAT2, 2, _buf2);

		if (ret < 0) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE