Commit 72a81ad9 authored by Heiko Carstens's avatar Heiko Carstens Committed by Vasily Gorbik
Browse files

s390/smp: fix physical to logical CPU map for SMT 



If an SMT capable system is not IPL'ed from the first CPU the setup of
the physical to logical CPU mapping is broken: the IPL core gets CPU
number 0, but then the next core gets CPU number 1. Correct would be
that all SMT threads of CPU 0 get the subsequent logical CPU numbers.

This is important since a lot of code (like e.g. the CPU topology
code) assumes that CPU maps are setup like this. If the mapping is
broken the system will not IPL due to broken topology masks:

[    1.716341] BUG: arch topology broken
[    1.716342]      the SMT domain not a subset of the MC domain
[    1.716343] BUG: arch topology broken
[    1.716344]      the MC domain not a subset of the BOOK domain

This scenario can usually not happen since LPARs are always IPL'ed
from CPU 0 and also re-IPL is intiated from CPU 0. However older
kernels did initiate re-IPL on an arbitrary CPU. If therefore a re-IPL
from an old kernel into a new kernel is initiated this may lead to
crash.

Fix this by setting up the physical to logical CPU mapping correctly.

Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent c2313594

arch/s390/kernel/smp.c

+54 −26
Original line number Diff line number Diff line
@@ -724,39 +724,67 @@ static void __ref smp_get_core_info(struct sclp_core_info *info, int early) 


static int smp_add_present_cpu(int cpu);



static int __smp_rescan_cpus(struct sclp_core_info *info, int sysfs_add)

static int smp_add_core(struct sclp_core_entry *core, cpumask_t *avail,

			bool configured, bool early)

{

	struct pcpu *pcpu;

	cpumask_t avail;

	int cpu, nr, i, j;

	int cpu, nr, i;

	u16 address;



	nr = 0;

	cpumask_xor(&avail, cpu_possible_mask, cpu_present_mask);

	cpu = cpumask_first(&avail);

	for (i = 0; (i < info->combined) && (cpu < nr_cpu_ids); i++) {

		if (sclp.has_core_type && info->core[i].type != boot_core_type)

			continue;

		address = info->core[i].core_id << smp_cpu_mt_shift;

		for (j = 0; j <= smp_cpu_mtid; j++) {

			if (pcpu_find_address(cpu_present_mask, address + j))

	if (sclp.has_core_type && core->type != boot_core_type)

		return nr;

	cpu = cpumask_first(avail);

	address = core->core_id << smp_cpu_mt_shift;

	for (i = 0; (i <= smp_cpu_mtid) && (cpu < nr_cpu_ids); i++) {

		if (pcpu_find_address(cpu_present_mask, address + i))

			continue;

		pcpu = pcpu_devices + cpu;

			pcpu->address = address + j;

			pcpu->state =

				(cpu >= info->configured*(smp_cpu_mtid + 1)) ?

				CPU_STATE_STANDBY : CPU_STATE_CONFIGURED;

		pcpu->address = address + i;

		if (configured)

			pcpu->state = CPU_STATE_CONFIGURED;

		else

			pcpu->state = CPU_STATE_STANDBY;

		smp_cpu_set_polarization(cpu, POLARIZATION_UNKNOWN);

		set_cpu_present(cpu, true);

			if (sysfs_add && smp_add_present_cpu(cpu) != 0)

		if (!early && smp_add_present_cpu(cpu) != 0)

			set_cpu_present(cpu, false);

		else

			nr++;

			cpu = cpumask_next(cpu, &avail);

			if (cpu >= nr_cpu_ids)

		cpumask_clear_cpu(cpu, avail);

		cpu = cpumask_next(cpu, avail);

	}

	return nr;

}



static int __smp_rescan_cpus(struct sclp_core_info *info, bool early)

{

	struct sclp_core_entry *core;

	cpumask_t avail;

	bool configured;

	u16 core_id;

	int nr, i;



	nr = 0;

	cpumask_xor(&avail, cpu_possible_mask, cpu_present_mask);

	/*

	 * Add IPL core first (which got logical CPU number 0) to make sure

	 * that all SMT threads get subsequent logical CPU numbers.

	 */

	if (early) {

		core_id = pcpu_devices[0].address >> smp_cpu_mt_shift;

		for (i = 0; i < info->configured; i++) {

			core = &info->core[i];

			if (core->core_id == core_id) {

				nr += smp_add_core(core, &avail, true, early);

				break;

			}

		}

	}

	for (i = 0; i < info->combined; i++) {

		configured = i < info->configured;

		nr += smp_add_core(&info->core[i], &avail, configured, early);

	}

	return nr;

}
@@ -805,7 +833,7 @@ void __init smp_detect_cpus(void) 


	/* Add CPUs present at boot */

	get_online_cpus();

	__smp_rescan_cpus(info, 0);

	__smp_rescan_cpus(info, true);

	put_online_cpus();

	memblock_free_early((unsigned long)info, sizeof(*info));

}
@@ -1148,7 +1176,7 @@ int __ref smp_rescan_cpus(void) 
	smp_get_core_info(info, 0);

	get_online_cpus();

	mutex_lock(&smp_cpu_state_mutex);

	nr = __smp_rescan_cpus(info, 1);

	nr = __smp_rescan_cpus(info, false);

	mutex_unlock(&smp_cpu_state_mutex);

	put_online_cpus();

	kfree(info);

CRA Git | Maintained and supported by SUSTech CRA and CCSE