Commit 72923555 authored Feb 11, 2016 by Eric Dumazet Committed by David S. Miller Feb 16, 2016

tcp: md5: release request socket instead of listener



If tcp_v4_inbound_md5_hash() returns an error, we must release
the refcount on the request socket, not on the listener.

The bug was added for IPv4 only.

Fixes: 079096f1 ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 37202283

net/ipv4/tcp_ipv4.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1600,8 +1600,10 @@ process:
		struct sock *nsk = NULL;

		sk = req->rsk_listener;
		if (tcp_v4_inbound_md5_hash(sk, skb))
		goto discard_and_relse;
		if (unlikely(tcp_v4_inbound_md5_hash(sk, skb))) {
		reqsk_put(req);
		goto discard_it;
		}
		if (likely(sk->sk_state == TCP_LISTEN)) {
		nsk = tcp_check_req(sk, skb, req, false);
		} else {

Admin message