Commit 728deecd authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix possible NULL dereference in snd_hda_get_pin_label() 



Fix a possible NULL access of indexp in fill_audio_out_name() called
from snd_hda_get_pin_label().

Spotted by coverity CID 402035.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9b389a8a

sound/pci/hda/hda_auto_parser.c

+1 −1
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ static int fill_audio_out_name(struct hda_codec *codec, hda_nid_t nid, 
			/* don't add channel suffix for Headphone controls */

			int idx = get_hp_label_index(codec, nid, cfg->hp_pins,

						     cfg->hp_outs);

			if (idx >= 0)

			if (idx >= 0 && indexp)

				*indexp = idx;

			sfx = "";

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE