Commit 7277a34c authored Nov 08, 2019 by Peter Zijlstra Committed by Ingo Molnar Nov 11, 2019

sched/fair: Better document newidle_balance()



Whilst chasing the pick_next_task() race, there was some confusion
about the newidle_balance() return values. Document them.

[ mingo: Minor edits. ]

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bsegall@google.com
Cc: dietmar.eggemann@arm.com
Cc: juri.lelli@redhat.com
Cc: ktkhai@virtuozzo.com
Cc: mgorman@suse.de
Cc: qais.yousef@arm.com
Cc: qperret@google.com
Cc: rostedt@goodmis.org
Cc: valentin.schneider@arm.com
Cc: vincent.guittot@linaro.org
Link: https://lkml.kernel.org/r/20191108131909.488364308@infradead.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 6d5a763c

kernel/sched/fair.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -9941,6 +9941,11 @@ static inline void nohz_newidle_balance(struct rq *this_rq) { }
		/*
		* idle_balance is called by schedule() if this_cpu is about to become
		* idle. Attempts to pull tasks from other CPUs.
		*
		* Returns:
		* < 0 - we released the lock and there are !fair tasks present
		* 0 - failed, no new tasks
		* > 0 - success, new (fair) tasks present
		*/
		int newidle_balance(struct rq this_rq, struct rq_flags rf)
		{

Admin message