Commit 726b55d0 authored Oct 09, 2019 by Johan Hovold Committed by Greg Kroah-Hartman Oct 10, 2019

USB: legousbtower: fix use-after-free on release



The driver was accessing its struct usb_device in its release()
callback without holding a reference. This would lead to a
use-after-free whenever the device was disconnected while the character
device was still open.

Fixes: fef526ca ("USB: legousbtower: remove custom debug macro")
Cc: stable <stable@vger.kernel.org>     # 3.12
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009153848.8664-5-johan@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent eb21a74a

drivers/usb/misc/legousbtower.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -296,6 +296,7 @@ static inline void tower_delete (struct lego_usb_tower *dev)
		kfree (dev->read_buffer);
		kfree (dev->interrupt_in_buffer);
		kfree (dev->interrupt_out_buffer);
		usb_put_dev(dev->udev);
		kfree (dev);
		}

		@@ -810,7 +811,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device

		mutex_init(&dev->lock);

		dev->udev = udev;
		dev->udev = usb_get_dev(udev);
		dev->open_count = 0;
		dev->disconnected = 0;

Admin message