Commit 72579e14 authored Apr 21, 2020 by Vladimir Oltean Committed by David S. Miller Apr 22, 2020

net: dsa: don't fail to probe if we couldn't set the MTU

There is no reason to fail the probing of the switch if the MTU couldn't
be configured correctly (either the switch port itself, or the host
port) for whatever reason. MTU-sized traffic probably won't work, sure,
but we can still probably limp on and support some form of communication
anyway, which the users would probably appreciate more.

Fixes: bfcb8132 ("net: dsa: configure the MTU for switch ports")
Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a1211bf9

net/dsa/slave.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -1770,11 +1770,9 @@ int dsa_slave_create(struct dsa_port *port)
		rtnl_lock();
		ret = dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN);
		rtnl_unlock();
		if (ret && ret != -EOPNOTSUPP) {
		dev_err(ds->dev, "error %d setting MTU on port %d\n",
		if (ret)
		dev_warn(ds->dev, "nonfatal error %d setting MTU on port %d\n",
		ret, port->index);
		goto out_free;
		}

		netif_carrier_off(slave_dev);

Admin message