Commit 7210c678 authored Oct 20, 2007 by Kyle McMartin

[PARISC] fix uninitialized variable warning in asm/rtc.h



get_rtc_time, in the case that PDC returns that the battery is bad, returns
an unmodified rtc_time arg to the caller, which then uses uninitialized
values. Fix this by memset-ing the arg with zeroes, so it will at least be
cleared if we return failure.

Spotted by John David Anglin.

Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>

parent 562d139c

include/asm-parisc/rtc.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -50,10 +50,10 @@ static inline unsigned int get_rtc_time(struct rtc_time *wtime)
		long int days, rem, y;
		const unsigned short int *ip;

		memset(wtime, 0, sizeof(*wtime));
		if (pdc_tod_read(&tod_data) < 0)
		return RTC_24H \| RTC_BATT_BAD;


		// most of the remainder of this function is:
		// Copyright (C) 1991, 1993, 1997, 1998 Free Software Foundation, Inc.
		// This was originally a part of the GNU C Library.

Admin message