Commit 720a650f authored Sep 28, 2007 by Herbert Xu Committed by David S. Miller Oct 10, 2007

[CRYPTO] cryptomgr: Fix parsing of recursive algorithms

As Joy Latten points out, inner algorithm parameters will miss the closing
bracket which will also cause the outer algorithm to terminate prematurely.

This patch fixes that also kills the WARN_ON if the number of parameters
exceed the maximum as that is a user error.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent f19f5111

crypto/cryptomgr.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -129,6 +129,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
		}

		notnum = 1;
		p++;
		}

		len = p - name;
		@@ -151,7 +152,7 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
		param->tb[i + 1] = &param->attrs[i].attr;
		i++;

		if (WARN_ON(i >= CRYPTO_MAX_ATTRS))
		if (i >= CRYPTO_MAX_ATTRS)
		goto err_free_param;

		if (*p == ')')

Admin message