Commit 71fed0bc authored Jul 31, 2020 by Gaurav Singh Committed by David S. Miller Aug 03, 2020

ethtool: ethnl_set_linkmodes: remove redundant null check



info cannot be NULL here since its being accessed earlier
in the function: nlmsg_parse(info->nlhdr...). Remove this
redundant NULL check.

Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9aba6c5b

net/ethtool/linkmodes.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -421,7 +421,6 @@ int ethnl_set_linkmodes(struct sk_buff skb, struct genl_info info)

		ret = __ethtool_get_link_ksettings(dev, &ksettings);
		if (ret < 0) {
		if (info)
		GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
		goto out_ops;
		}

Admin message